CI workflow and CS fixer updates#198
Merged
TheWitness merged 6 commits intoCacti:developfrom Feb 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request performs comprehensive code quality improvements across the Monitor plugin codebase, primarily implementing PHP-CS-Fixer style changes. Additionally, it introduces CI/CD infrastructure and GitHub Copilot agent definitions. Despite the PR title "Csfixer" suggesting code style fixes, the description emphasizes agent definitions, which represents a minor discrepancy.
Changes:
- Modernized PHP syntax: converted
array()to[],/* */to//comments,else iftoelseif - Removed trailing whitespace and blank lines across all PHP files
- Improved code formatting: operator spacing, string concatenation, function call alignment
- Added GitHub Actions CI workflow for integration testing across PHP 8.1-8.4 and MariaDB 10.6
- Introduced GitHub Copilot instructions and specialized agent definitions (triage, code quality, PHP developer, MySQL/MariaDB DBA)
- Added
vendor/to.gitignore
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.php | Modernized array syntax, comment style, control structures, and spacing throughout plugin setup code |
| poller_monitor.php | Applied consistent formatting to poller script including array syntax and comment style updates |
| monitor.php | Comprehensive formatting improvements to main UI controller following same patterns |
| themes/*/index.php | Removed trailing blank lines |
| sounds/index.php | Removed trailing blank line |
| locales/*/index.php | Removed trailing blank lines |
| index.php | Removed trailing blank line |
| .gitignore | Added vendor/ directory exclusion |
| .github/workflows/plugin-ci-workflow.yml | New CI workflow for integration testing |
| .github/copilot-instructions.md | New Copilot guidance document |
| .github/agents/*.agent.md | New agent definitions for triage, code quality, PHP development, and database administration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
TheWitness
approved these changes
Feb 14, 2026
TheWitness
approved these changes
Feb 14, 2026
browniebraun
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces four new custom agent definitions to the
.github/agentsdirectory, each designed to handle a specific area of expertise within the project. These agents are described in markdown files and include clear instructions, capabilities, and tool access. The main themes are the introduction of specialized agents for triage, code quality, PHP development, and MySQL/MariaDB database administration.New Agent Definitions:
Agent Coordination and Routing:
Triage Agent(triage_agent.md.agent.md) that receives user requests, analyzes them, and delegates tasks to specialized agents using explicit routing rules and a deterministic matching strategy. The agent includes detailed instructions, sample routing rules, and a delegation payload template.Code Quality and Development:
Code Quality Specialistagent (code-quality.agent.md) focused on code review, refactoring, testing, documentation, performance optimization, and security best practices for a LAMP stack with JavaScript frontend.PHP Developeragent (php-developer.agent.md) specializing in PHP code development, debugging, optimization, and adherence to PSR-12 standards, with references to Cacti project functions and documentation.Database Administration:
MySQL/MariaDB Database Administratoragent (mysql-mariadb.agent.md) to assist with database management, query optimization, troubleshooting, backup/recovery, security, and scripting, including references to built-in Cacti DB functions and relevant documentation.